Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension: add button-clicks #4842

Merged
merged 3 commits into from
Oct 14, 2022

Conversation

martinwork
Copy link
Contributor

@abchatra
Copy link
Contributor

Looks good overall. Nice extension.

Minor nit: @bsiever can you remove more category. It is just few blocks and more category is not recommended when you have less than 10 blocks. Put the more category blocks lower in the hierarchy.
image

@abchatra
Copy link
Contributor

@martinwork please add @ me to these extensions PR. I will miss it otherwise.

@martinwork
Copy link
Contributor Author

Will do, thanks @abchatra

@bsiever
Copy link

bsiever commented Oct 14, 2022

@abchatra: I'm open to that, but I was a little afraid that the features I put in "More" (referred to as advanced in the markup for toolbox placement) aren't really the core functionality and may add some confusion about which blocks to use. But I agree that it's a little silly to have a separate toolbox spot just for two blocks. Thoughts?

@bsiever
Copy link

bsiever commented Oct 14, 2022

@abchatra Ignore my previous post. I removed the "More" category and used an "Advanced" group for those two blocks (forgot that was possible until I was doing something else). Update has been committed.

@abchatra abchatra merged commit 06e2d80 into microsoft:master Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants